Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fleet cattle healthcheck #12288

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #12259

Occurred changes and/or fixed issues

This PR tweaks the logic used to show fleet and cattle agent statuses on the cluster explorer dashboard. Previously we checked that the user was able to list deployments; now we check that they can see the namespace the deployments would be in.

Technical notes summary

Areas or cases that should be tested

Cluster explorer dashboard with both local and downstream clusters (local will not show cattle agent), both as admin and a user with project membership only, as outlined in #12259

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a test with both admin and standard users I local and rk2 digital ocean cluster and everything seems to fine. Codewise it also looks good, so overall LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants