Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include gke zone in list of extra locations #12289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mantis-toboggan-md
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md commented Oct 17, 2024

Summary

Fixes #12261
Fixes #12260

Occurred changes and/or fixed issues

updates the GKE provisioning form so that when a user selects a zone, the locations field (which otherwise maps to the list of extra zones) includes that zone.

Areas or cases that should be tested

  1. Create a 'zonal' GKE cluster without adding zones (default configuration), wait for the cluster to become active
  2. Once the cluster has finished provisioning verify that you can edit it and add extra zones (gkeConfig.locations in the save request), and that the cluster is eventually 'active' again
  3. Create a new 'zonal' gke cluster and define extra zones initially
  4. Wait for the cluster to provision; verify that you can add/remove extra zones

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKE - Unable to provision cluster with extra zones GKE - Unable to edit cluster zones
1 participant