Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyboard nav on settings page #13123

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

aalves08
Copy link
Member

Summary

Fixes #12787

Occurred changes and/or fixed issues

  • fix keyboard nav on settings list page
  • settings edit page

Technical notes summary

NOTE: edit setting action menu on each setting will be fixed by #13019

  • improved show/hide settings list template because it was reliant on a v-if and rendered 2 different buttons that essentially worked as toggle
  • needed to tweak the masthead component so that the focus-visible CSS state for the title link is actually visible for the user
  • also verified that Projects with long Display Names do not get truncated #9790 did not regress

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We're obviously missing a lot of benefit that we would get from the Dropdown Menu component.

@aalves08 aalves08 merged commit c6db1b7 into rancher:master Jan 23, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Fix keyboard navigation and focus display for Global Settings
2 participants