-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix key nav on charts page #13139
fix key nav on charts page #13139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes at the core of this PR are good, but it looks like quite a few changes from other PRs are represented here as well. Do we intend to rebase this after other PRs have merged?
ed430f0
to
a7f5fb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a7f5fb0
to
9e6a8e6
Compare
@@ -74,6 +74,7 @@ | |||
color: var(--dropdown-text); | |||
white-space: nowrap; | |||
z-index: 1000; | |||
overflow: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aalves08 this has caused a regression for the repos dropdown on the Charts page
Summary
Fixes #12783
Occurred changes and/or fixed issues
charts
pageSelect
component implementation so that it opens on enter/space and not open just on focusSelectIconGrid
so that it allows for keyboard navCarousel
so that it allows for keyboard navTechnical notes summary
There's a bug on the
Rules
tab iningress
create screen #13147 that is proven not to be related to any change of this PR. Ignore it if testingSelect
's on that area.Areas or cases that should be tested
charts
pageSelectIconGrid
is implemented (navlink groups, cluster provisioning, charts, auth provider)Areas which could experience regressions
Select
's thoroughly throughout the UI, especially more "exotic" implementations. Basic use case should be covered.Screenshot/Video
Checklist