Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix key nav on charts page #13139

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Jan 16, 2025

Summary

Fixes #12783

Occurred changes and/or fixed issues

  • Fixes keyboard navigation on the charts page
  • Fixes Select component implementation so that it opens on enter/space and not open just on focus
  • Fixes SelectIconGrid so that it allows for keyboard nav
  • Fixes Carousel so that it allows for keyboard nav

Technical notes summary

There's a bug on the Rules tab in ingress create screen #13147 that is proven not to be related to any change of this PR. Ignore it if testing Select's on that area.

Areas or cases that should be tested

  • test charts page
  • test areas where SelectIconGrid is implemented (navlink groups, cluster provisioning, charts, auth provider)

Areas which could experience regressions

  • Test Select's thoroughly throughout the UI, especially more "exotic" implementations. Basic use case should be covered.

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes at the core of this PR are good, but it looks like quite a few changes from other PRs are represented here as well. Do we intend to rebase this after other PRs have merged?

shell/assets/styles/base/_mixins.scss Outdated Show resolved Hide resolved
@aalves08 aalves08 force-pushed the 12783-key-nav-charts-grid branch from ed430f0 to a7f5fb0 Compare January 23, 2025 11:04
@aalves08 aalves08 requested a review from rak-phillip January 23, 2025 13:56
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 force-pushed the 12783-key-nav-charts-grid branch from a7f5fb0 to 9e6a8e6 Compare January 24, 2025 09:42
@aalves08 aalves08 merged commit 3b0418f into rancher:master Jan 24, 2025
32 checks passed
@@ -74,6 +74,7 @@
color: var(--dropdown-text);
white-space: nowrap;
z-index: 1000;
overflow: auto;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aalves08 this has caused a regression for the repos dropdown on the Charts page

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Fix keyboard navigation and focus display for charts grid
3 participants