Fleet: expose Polling Interval for GitRepos

[torchiaf]

Summary

Fixes #7824

Occurred changes and/or fixed issues

We are adding the possibility to:

• enable/disable polling.
• set up the pollingInterval value when creating/editing GitRepos.

Technical notes summary

• It should be possible to enable/disable polling
• It should be possible to assign the polling interval in edit mode and display the value in view mode
• Default Polling Interval should be 60 seconds when creating new GitRepo
• The value in the input field should be 15 seconds when editing a GitRepo and spec.pollingInterval is undefined
• A warning should be displayed in case of the polling interval is lower than 15 seconds
• A warning should be displayed in case of a webhook is configured https://fleet.rancher.io/webhook

Areas or cases that should be tested

GitRepo, edit page

Areas which could experience regressions

Screenshot/Video

Create/Edit

Screencast.from.2025-02-13.17-48-28.webm

View

Tooltip

Warning, the interval is lower than the recommended value

Warning, a webhook is configured

Enable/Disable Polling action

Checklist

• The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
• The PR has a Milestone
• The PR template has been filled out
• The PR has been self reviewed
• The PR has a reviewer assigned
• The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
• The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

[torchiaf]

@manno could you please help reviewing the text messages ? I'm not sure if Syncronization as section title is appropriate and tooltip/warning messages could be improved.

[manno]

I would suggest "polling", that's what we use for the fields and in the documentation. It describes the cyclic requests well.

[torchiaf]

Done, thanks.

[manno]

I would suggest to use a larger default values, like a minute. It depends on the installation, but larger fleets might use an interval of 1 hour.

Note, there is some interaction with https://fleet.rancher.io/webhook

If you configured the webhook the polling interval will be automatically adjusted to 1 hour.

Additionally, setting paused: true on the GitRepo does not disable polling. To disable polling completely users can set
disablePolling: true (https://fleet.rancher.io/ref-gitrepo).

[richard-cox]

@edenhernandez-suse Are we sure we want to stick on another setting to this step in the wizard? the page is already pretty tall

It feels like we should redistribute components into modified steps

1. basics - name / namespace, labels, annotations
2. source specific - repo / branch, path, git auth
3. functional specific - syncronization, helm auth, TLS verification, resource handling, soon oci repo details
4. cluster target details

@manno do those groups make sense?

Edit: We also need to optimise for the simple case, whilst still allowing users to configured more advanced settings.

Maybe the best option is to have step 3 as Advanced Options? so steps relabelled and organised would be...

1. Resource - name / namespace, labels, annotations
2. Source - repo / branch, path, git auth
3. Target - cluster selection / selector
4. Advanced - syncronization, helm auth, TLS verification, resource handling, soon oci repo details (order tbd)

[torchiaf]

@richard-cox @edenhernandez-suse I'd move the wizard refactoring in another issue/PR, since this change it's becoming huge considering that we have to add the Disable Polling field and weebhook detection.

[richard-cox]

@torchiaf ok. can you create an issue to address the vertical height of fields in that first step, and reference my comment as a possible solution?

[torchiaf]

@richard-cox @edenhernandez-suse I created this one that summarize steps and fields size improvements: #13402