RKE1 deprecation banner on cluster management page #13379
Conversation
|
@richard-cox re your comment about relying on the new flag, I discussed it with @codyrancher and since those changes might not end up in 2.11 we should go with the existing |
There was a problem hiding this comment.
@codyrancher can you make sure the update to support this is in vai world tracked somewhere?
There was a problem hiding this comment.
one text suggestion, also the issue mentions showing a warning on the create/edit screen. if we show it there we should probably also show it in the detail page as well?
if not already, this should have a general UX review including the additional places to show the warning
| @@ -1871,6 +1871,7 @@ cluster: | |||
| =1 { {pool_name}: The provided value for {fields} was not found in the list of expected values. This can happen with clusters provisioned outside of Rancher or when options for the provider have changed. } | |||
| other { {pool_name}: The provided values for {fields} were not found in the list of expected values. This can happen with clusters provisioned outside of Rancher or when options for the provider have changed. } | |||
| } | |||
| rke1DeprecationMessage: 'Rancher Kubernetes Engine (RKE, RKE1) will reach end of life on July 31, 2025. Rancher 2.12.0 and later will no longer support provisioning or managing downstream RKE1 clusters. We recommend replatforming RKE1 clusters to RKE2 to ensure continued support and security updates. Learn more about the transition <a href="https://www.suse.com/support/kb/doc/?id=000021518" target="_blank" rel="noopener noreferrer nofollow">here</a>.' | |||
There was a problem hiding this comment.
| rke1DeprecationMessage: 'Rancher Kubernetes Engine (RKE, RKE1) will reach end of life on July 31, 2025. Rancher 2.12.0 and later will no longer support provisioning or managing downstream RKE1 clusters. We recommend replatforming RKE1 clusters to RKE2 to ensure continued support and security updates. Learn more about the transition <a href="https://www.suse.com/support/kb/doc/?id=000021518" target="_blank" rel="noopener noreferrer nofollow">here</a>.' | |
| rke1DeprecationMessage: 'Rancher Kubernetes Engine (RKE / RKE1) will reach end of life on July 31, 2025. Rancher 2.12.0 and later will no longer support provisioning or managing downstream RKE1 clusters. We recommend replatforming RKE1 clusters to RKE2 to ensure continued support and security updates. Learn more about the transition <a href="https://www.suse.com/support/kb/doc/?id=000021518" target="_blank" rel="noopener noreferrer nofollow">here</a>.' |
There was a problem hiding this comment.
This has undergone a general ux/ui review, but I think your feedback on adding the banner to the details page really makes sense. I'll address your comments.
There was a problem hiding this comment.
I think another good place to display this banner would be the create cluster page where we have the RKE1/RKE2 toggle, and only show it when RKE1 is active. I'll have a meeting with Ken to review your suggestion as well as mine.
Summary
Fixes #13284
Technical notes summary
A warning banner will be displayed on the Cluster Management page only if at least one RKE1 cluster is installed. It relies on the existing flag
isRke1().Since this is not a permanent change a manual testing will be sufficient.
Areas or cases that should be tested
Try adding and removing an RKE1 cluster to make sure it's displayed properly.
Areas which could experience regressions
Screenshot/Video
dep.mov
Checklist