Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document managedosimage lifecycle #440

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

anmazzotti
Copy link
Contributor

Closes #436

@anmazzotti anmazzotti self-assigned this Nov 15, 2024
@anmazzotti anmazzotti requested a review from a team as a code owner November 15, 2024 10:06
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for elemental-docs-staging ready!

Name Link
🔨 Latest commit f322065
🔍 Latest deploy log https://app.netlify.com/sites/elemental-docs-staging/deploys/67458da3874d580008236846
😎 Deploy Preview https://deploy-preview-440--elemental-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@@ -12,6 +12,8 @@ import ClusterTarget from "!!raw-loader!@site/examples/upgrade/upgrade-cluster-t
# ManagedOSImage reference

The ManagedOSImage resource is responsible of defining an OS image or image version that needs to be applied to each node in a set of targeted Clusters.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the "following upgrade" at first read was not crystal clear to me... what about changing to something like "new upgrade" or "a brand new upgrade workflow" ?

Suggested change
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a new upgrade.

@@ -12,6 +12,8 @@ import ClusterTarget from "!!raw-loader!@site/examples/upgrade/upgrade-cluster-t
# ManagedOSImage reference

The ManagedOSImage resource is responsible of defining an OS image or image version that needs to be applied to each node in a set of targeted Clusters.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a new upgrade.

For example if the to-be-upgraded image is not found on the registry or otherwise broken, the upgrade job running on the downstream clusters will not succeed.

When this is the case, the nodes running the failing upgrade job will stay cordoned.
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo (missing 'n').

Suggested change
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
You can update the ManagedOSImage with a functioning reference image, or alternatively delete it to stop any further upgrade attempt.

@@ -12,6 +12,8 @@ import ClusterTarget from "!!raw-loader!@site/examples/upgrade/upgrade-cluster-t
# ManagedOSImage reference

The ManagedOSImage resource is responsible of defining an OS image or image version that needs to be applied to each node in a set of targeted Clusters.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a new upgrade.

For example if the to-be-upgraded image is not found on the registry or otherwise broken, the upgrade job running on the downstream clusters will not succeed.

When this is the case, the nodes running the failing upgrade job will stay cordoned.
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
You can update the ManagedOSImage with a functioning reference image, or alternatively delete it to stop any further upgrade attempt.

For example if the to-be-upgraded image is not found on the registry or otherwise broken, the upgrade job running on the downstream clusters will not succeed.

When this is the case, the nodes running the failing upgrade job will stay cordoned.
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
You can update the ManagedOSImage with a functioning reference image, or alternatively delete it to stop any further upgrade attempt.

@@ -12,6 +12,8 @@ import ClusterTarget from "!!raw-loader!@site/examples/upgrade/upgrade-cluster-t
# ManagedOSImage reference

The ManagedOSImage resource is responsible of defining an OS image or image version that needs to be applied to each node in a set of targeted Clusters.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a new upgrade.

For example if the to-be-upgraded image is not found on the registry or otherwise broken, the upgrade job running on the downstream clusters will not succeed.

When this is the case, the nodes running the failing upgrade job will stay cordoned.
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
You can update the ManagedOSImage with a functioning reference image, or alternatively delete it to stop any further upgrade attempt.

@@ -12,6 +12,8 @@ import ClusterTarget from "!!raw-loader!@site/examples/upgrade/upgrade-cluster-t
# ManagedOSImage reference

The ManagedOSImage resource is responsible of defining an OS image or image version that needs to be applied to each node in a set of targeted Clusters.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a following upgrade.
Once created, the ManagedOSImage resource can be updated with a new `osImage` or `managedOSVersionName` to trigger a new upgrade.

For example if the to-be-upgraded image is not found on the registry or otherwise broken, the upgrade job running on the downstream clusters will not succeed.

When this is the case, the nodes running the failing upgrade job will stay cordoned.
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can update the ManagedOSImage with a functioing image reference, or alternatively delete it to stop any further upgrade attempt.
You can update the ManagedOSImage with a functioning reference image, or alternatively delete it to stop any further upgrade attempt.

@anmazzotti anmazzotti force-pushed the document_managedosimage_lifecycle branch from 043f084 to f322065 Compare November 26, 2024 08:58
@anmazzotti anmazzotti merged commit b8e30cc into rancher:main Nov 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Document ManagedOSImage expected lifecycle
2 participants