Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HowTo: cover Rancher Provisioning IP options #447

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

fgiudici
Copy link
Member

@fgiudici fgiudici commented Nov 26, 2024

Share the Elemental way to configure the Internal and the External IP addresses in K3s and RKE2

Fixes #445

Signed-off-by: Francesco Giudici <[email protected]>
Share the Elemental way to configure the Internal and the External IP
addresses in K3s and RKE2

Signed-off-by: Francesco Giudici <[email protected]>
@fgiudici fgiudici requested a review from a team as a code owner November 26, 2024 14:38
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for elemental-docs-staging ready!

Name Link
🔨 Latest commit c76aa46
🔍 Latest deploy log https://app.netlify.com/sites/elemental-docs-staging/deploys/6745dd750854d400088c6ebf
😎 Deploy Preview https://deploy-preview-447--elemental-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks good, however I looked at the code and I do not understand how this actually works. All I see is that these labels are used to update the MachineSelector.status. Going to trust you on this one, but looks like magic to me. :P

@fgiudici
Copy link
Member Author

Documentation looks good, however I looked at the code and I do not understand how this actually works. All I see is that these labels are used to update the MachineSelector.status. Going to trust you on this one, but looks like magic to me. :P

Yeah, the MachineSelector.status is picked up by Rancher provisioning 🪄
I tried it with a PoC successfully but will double check with the actual code the full workflow is working before merging 👍🏼

@fgiudici
Copy link
Member Author

Basic test was successful: merging...

@fgiudici fgiudici merged commit 16342fb into rancher:main Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Document how to configure InternalIP and ExternalIP addresses for k3s/RKE2 provisioning
2 participants