[v0.7] Backport helm release name fix #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a release name must be truncated to comply with Helm's maximum release name length, Fleet truncates the name and builds a new release name as `<name>-<hash>`. In cases where the last character of `<name>` is a dash, a previous commit would include the character immediately following the dash and place it before the hash, which might cause confusion. Instead, this commit does not include that character in such cases and increases the hash length by 1, so that characters after the last dash in the release name remain hexadecimal. Avoid increasing hex length if truncated string ends with - In such cases, the separator is simply omitted. The resulting string will be one character shorter than the limit, which should not cause any issues. On the other hand, the hash will contain only hexadecimal digits, as it previously did. Since double dashes are not part of the result, this preserves consistency across repeated calls, and hence between bundle ID and Helm release name, thereby preventing unexpected deletion and re-creation of bundles. Co-authored-by: Corentin Néau <[email protected]>
weyfonk
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #1660