Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements DependencyUpdate for helm charts #2135

Merged
merged 5 commits into from
Feb 16, 2024

Commits on Feb 9, 2024

  1. Implements DependencyUpdate for helm charts

    A new flag `disableDependencyUpdate` is added to the `fleet.yaml`
    file in order to disable the feature, which is active by default.
    
    A new package `helmupdater` is added to implement the dependencies
    update.
    The implementation is based on helm's when ussing the
    `--dependency-update` flag in the install command.
    
    Dependencies are applied to the bundle (upstream) to they're resolved
    already when applying downstream.
    
    Refers to: rancher#1672
    
    Signed-off-by: Xavi Garcia <[email protected]>
    0xavi0 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    999dc47 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Changes after code-review

    Signed-off-by: Xavi Garcia <[email protected]>
    0xavi0 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    702ba99 View commit details
    Browse the repository at this point in the history
  2. Change function name to make it go-idiomatic

    Signed-off-by: Xavi Garcia <[email protected]>
    0xavi0 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    527b259 View commit details
    Browse the repository at this point in the history
  3. Change parameter name to make it shorter

    Changed from disableDependencyUpdate to disableDepsUpdate
    
    Signed-off-by: Xavi Garcia <[email protected]>
    0xavi0 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    6a471d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Delete Eventually and add Gomega custom matchers

    Eventually is not needed when testing for resources in bundles as we get
    the bundle from `cli.GetBundleListFromOutput` and the buffer read will be
    in its final state once `cli.GetBundleListFromOutput` returns.
    
    Also addind custom Gomega matchers to avoid using helper functions and
    to get the exact line when any test assertion fails.
    
    Already existing tests have been changed to use the custom matchers and
    don't use Eventually, also.
    
    Signed-off-by: Xavi Garcia <[email protected]>
    0xavi0 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    28c9c5b View commit details
    Browse the repository at this point in the history