Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleet's helmdeployer used the wranger/apply module to do a "DryRun" to find modified objects.
Apply is very configurable, however Fleet only used a specific set of options. The relevant code paths to build the "plan" have been copied into the "deployer" packager. Several options, parameters, interfaces and switches have been removed.
one as "apply" is embedded in "desiredset"
Notes
patch:
field is populated by the "dryrun" code, but always overwritten by the "diff" code. It's only calculated to fill theplan.Update
struct. That struct is similar to theplan.Objects' struct and
Diffalready skips non modified resources. Data structures are different enough to make an optimization complicated, though. So removing
plan.Update` is not part of this PR.