Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes job handling in gitops controller #2903

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Changes job handling in gitops controller #2903

merged 3 commits into from
Oct 1, 2024

Commits on Oct 1, 2024

  1. Changes job handling in gitopts controller 

    Changes the job handling so jobs are deleted after they succeed.
Jobs are created when they are needed, this avoids having always a minimum of 1 job per
`gitrepo` resource.

It also deletes the Owns(job) statement from the reconciler setup as we're already setting
the controller reference when creating the job and the Owns statement makes extra reconciler
calls that are not needed.

Signed-off-by: Xavi Garcia <[email protected]>
    @0xavi0
    0xavi0 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bc3b782 View commit details
    Browse the repository at this point in the history

  2. Update after code review 

    Signed-off-by: Xavi Garcia <[email protected]>
    @0xavi0
    0xavi0 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    453ceea View commit details
    Browse the repository at this point in the history

  3. Make Commit and WehookCommit +optional instead of +nullable 

    Signed-off-by: Xavi Garcia <[email protected]>
    @0xavi0
    0xavi0 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    abb0244 View commit details
    Browse the repository at this point in the history