Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.10] Fix namespace target customization with no defaults #3085

Conversation

weyfonk
Copy link
Contributor

@weyfonk weyfonk commented Nov 15, 2024

Backport of #3052 to v0.10.

…3052)

* Improve namespace target customization tests

These tests now verify that the created namespace does bear expected
labels and annotations.
This commit also paves the way for additional tests with customizations
over unconfigured namespace labels and annotations, which currently
cause a panic.

* Initialise options maps when empty

This prevents panics when namespace labels or annotations are
configured as target customizations over nonexistent defaults.

* Use main branch of `rancher/fleet-test-data

The required changes made in that repo have been merged.
This fixes `requeueing` as `requeuing` and should make our typos Github
action happy.
@weyfonk weyfonk requested a review from a team as a code owner November 15, 2024 12:32
@weyfonk weyfonk closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant