Add benchmark suite #3120
Open
Add benchmark suite #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manno
force-pushed
the
benchmark-suite
branch
5 times, most recently
from
095a595 to
674be05
Compare
manno
force-pushed
the
benchmark-suite
branch
from
674be05 to
0ea917e
Compare
manno
force-pushed
the
benchmark-suite
branch
2 times, most recently
from
b1ab9b0 to
082b115
Compare
weyfonk
reviewed
Dec 17, 2024
Comment on lines
+173
to
+177
| } else if len(image.Names) > 1 { | ||
| name = image.Names[1] | ||
| } else { | ||
| name = image.Names[0] | ||
| } |
There was a problem hiding this comment.
What's the rationale for this?
There was a problem hiding this comment.
images:
- names:
- docker.io/rancher/fleet:dev
sizeBytes: 419817115
- names: null
sizeBytes: 399360934
- names:
- ghcr.io/rancherlabs/delve-debugger@sha256:d397fc318f7a5bd06304f15ad0aa07346d7dbcb3690637efd3663b8a5554c844
- ghcr.io/rancherlabs/delve-debugger:latest
sizeBytes: 360158186
We need to pick one of the names, on k3d the second name is better.
There was a problem hiding this comment.
Oh I see, thanks for clarifying. A brief comment explaining this would be great :)
* add benchmarks * add test data * experiments use group label instead of repo-name label w fleet 0.9.11 * add toggle for metrics * script uses stable benchmark order via --seed * check for at least one cluster * skip confusing report table printing as we don't use sampling
manno
force-pushed
the
benchmark-suite
branch
from
082b115 to
a0142f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO