Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry reconcile when we cannot add finalizer to content resource #3310

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

manno
Copy link
Member

@manno manno commented Feb 6, 2025

Noticed while reading logs. Also makes bundledeployment creation logging visible at INFO.

// fleet-controller-686cbf94bb-7zbnm fleet-controller 2025-02-05T17:16:04Z	ERROR	bundle	Reconcile failed to add content finalizer	{"controller": "bundle", "controllerGroup": "fleet.cattle.io", "controllerKind": "Bundle", "Bundle": {"name":"bm-1-gitrepo-1-bundle-benchmarks-create-1-gitre-773b4","namespace":"fleet-local"}, "namespace": "fleet-local", "name": "bm-1-gitrepo-1-bundle-benchmarks-create-1-gitre-773b4", "reconcileID": "9a95535b-199b-4478-b77b-fa5fae945a93", "gitrepo": "bm-1-gitrepo-1-bundle", "commit": "faca22290f9659e491e9a329ab3f23e6c9681139", "content ID": "s-bacd6eda76a6e0fef955f1656ac4d4bab9e0027580f1865a36689f71ae75a", "error": "resource name may not be empty"}

@manno manno requested a review from a team as a code owner February 6, 2025 15:36
@manno manno marked this pull request as draft February 6, 2025 15:36
@manno manno force-pushed the adding-content-finalizer-retries branch 4 times, most recently from 43faf06 to a709b34 Compare February 11, 2025 10:51
@manno manno marked this pull request as ready for review February 11, 2025 11:59
@manno manno force-pushed the adding-content-finalizer-retries branch from a709b34 to e427e6a Compare February 11, 2025 13:49
@manno manno force-pushed the adding-content-finalizer-retries branch 2 times, most recently from 4b1ab8e to 805f56f Compare February 12, 2025 10:10
@manno manno force-pushed the adding-content-finalizer-retries branch from 805f56f to 64941bc Compare February 12, 2025 10:25
@manno manno merged commit 0a7c3d6 into main Feb 12, 2025
11 of 12 checks passed
@manno manno deleted the adding-content-finalizer-retries branch February 12, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants