Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild rancher-project-monitoring chart based on 0.3.4 #139

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mallardduck
Copy link
Member

This PR does as it claims, it adds a new chart package that builds into the same chart artifacts. The benefit of this was to validate that the chart produced a nearly 1:1 replicate of 0.3.4 chart first. Then to update it to use the values from our updated rancher-monitoirng that's based on upstream 61.3.2.


The reason I opted to test this out and think it's better:

  • There's a lot of lost control by using the old method:
    • Specifically it ends up causing a lot of complicated rebasing,
    • The trade off for more simple rebasing is that we "own" these areas more,
  • When we need to update, we simply update the grafana sub chart, then can update the values.yaml images to match the same target version.

@mallardduck mallardduck requested a review from a team as a code owner December 19, 2024 20:39
@mallardduck mallardduck force-pushed the rebuild-rancher-project-monitoring branch from 8fa2ee2 to 372e668 Compare December 19, 2024 21:43
Copy link

Images built for PR #139:

  • Helm Locker - Tags:
    • ghcr.io/rancher/prometheus-federator/helm-locker:pr-139-b3aee70 ghcr.io/rancher/prometheus-federator/helm-locker:pr-139
  • Helm Project Operator - Tags:
    • ghcr.io/rancher/prometheus-federator/helm-project-operator:pr-139-b3aee70 ghcr.io/rancher/prometheus-federator/helm-project-operator:pr-139
  • Prometheus Federator - Tags:
    • ghcr.io/rancher/prometheus-federator:pr-139-b3aee70 ghcr.io/rancher/prometheus-federator:pr-139

Helm Debug Values:

  image:
    pullPolicy: Always
    registry: ghcr.io
    repository: rancher/prometheus-federator
    tag: pr-139-b3aee70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant