Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored icons for header #975

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Colored icons for header #975

merged 6 commits into from
Nov 3, 2023

Conversation

martyav
Copy link
Contributor

@martyav martyav commented Nov 2, 2023

Comments

This largely takes code from rancher/elemental-docs#235 (Thanks @nunix!)

I added the Elemental icon and tried to get a sharper version of the Rancher icon, as it looked blurry and stretched horizontally. The new icon is easier to see but cuts off half way, so it might need some CSS help.

The PR also includes some unused icons for other projects, in case we want to add those to the menu (Rancher Desktop, Kubewarden, Opni). Epinio and Elemental include those project links -- but Epinio only has Kubewarden and Opni, while Elemental only has Rancher Desktop -- so all our sites have different links in the dropdown. Should we be consistent across all websites or pick the top 4 other projects associated with each project website?

image

@btat
Copy link
Contributor

btat commented Nov 2, 2023

The PR also includes some unused icons for other projects, in case we want to add those to the menu (Rancher Desktop, Kubewarden, Opni).

IMO, we should only include the assets being used otherwise we just increase the repo size.

Epinio and Elemental include those project links -- but Epinio only has Kubewarden and Opni, while Elemental only has Rancher Desktop -- so all our sites have different links in the dropdown. Should we be consistent across all websites or pick the top 4 other projects associated with each project website?

This was previously discussed with @gunamata, but the list will always vary slightly because of the case where the given project site is in the list itself. The current implemented lists across project sites are based on the doc Guna provided.

src/css/custom.css Outdated Show resolved Hide resolved
@martyav martyav requested a review from btat November 3, 2023 18:07
@btat btat merged commit 5ddcc93 into rancher:main Nov 3, 2023
1 check passed
@martyav martyav deleted the colored-icons-header branch November 21, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants