cluster-dns add IPv6 to the documentation #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although RKE2 cluster DNS supports both IPv4 and IPv6, the documentation does not currently mention the option to use an IPv6 address for the cluster DNS. https://github.com/rancher/rke2/blob/9255fd8fa411695fc93573a6e6dfa9470e13e938/scripts/validate-charts#L54
brandond
approved these changes
Dec 24, 2024
|
Would you like me to submit a PR/MR to change the line you mentioned in the link? |
|
Yes, that'd be appreciated! |
|
Here is my PR on the k3s repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although RKE2 cluster DNS supports both IPv4 and IPv6, the documentation does not currently mention the option to use an IPv6 address for the cluster DNS. Similarly, users can specify an IPv4, IPv6, or dual-stack address for the cluster DNS.
https://github.com/rancher/rke2/blob/9255fd8fa411695fc93573a6e6dfa9470e13e938/scripts/validate-charts#L54