Add dumb watch mechanism for Vai #277
Conversation
There was a problem hiding this comment.
Questions:
- will changes to resources a user does not have access to still result in the resource counter increasing?
- do you have any plans to handle special Steve-only resources such as counters, that come with no revisions? How does watch work currently, can we keep the mechanism as-is?
| cancel() | ||
| }() | ||
| // XXX: Why was this needed at all?? | ||
| apiOp = apiOp.Clone().WithContext(ctx) |
There was a problem hiding this comment.
This was copied over from the non-SQLite implementation of Watch, which has this line:
steve/pkg/stores/partition/store.go
Line 295 in 99e479b
That seems to come from a distant past:
a9c39ef#diff-74cdf37ae3cf46d709e040c4c6e22a30e4b62586165b5f60c71f2e3f02514d98R132
The only reason I can see is we do not want to change the passed in apiOp, as it is passed by pointer. As Stores can be nested, I can see a calling Store not to expect the called Store to modify the passed apiOp to add a context to the nested Request the apiOp wraps.
So my understanding is that cloning here has the effect to have the context be applied to callees exclusively, but not callers. Whether this really prevents any bugs I am not sure.
| apiOp.Namespace = partition.Namespace | ||
| if partition.All { | ||
| return s.Watch(apiOp, schema, wr) | ||
| debounceListener := newDebounceListener(5 * time.Second) |
There was a problem hiding this comment.
Of course we will have to make sure the listener time is configurable - at least via configuration object or environment variable, in future possibly on a request-by-request basis.
Issue rancher/rancher#40773
Support watch with Vai using a debouncer