Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#47568 - Added delegateError + Improve delegate Test Coverage #318

Merged
merged 5 commits into from
Nov 14, 2024
Merged

#47568 - Added delegateError + Improve delegate Test Coverage #318

merged 5 commits into from
Nov 14, 2024

Conversation

gehrkefc
Copy link
Contributor

@gehrkefc gehrkefc commented Nov 7, 2024

This is related to issue: rancher/rancher#47568

@gehrkefc gehrkefc requested a review from a team as a code owner November 7, 2024 23:13
ericpromislow
ericpromislow reviewed Nov 9, 2024
View reviewed changes
pkg/ext/apiserver.go Outdated Show resolved Hide resolved
ericpromislow
ericpromislow requested changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo and some naming nits

tomleb
tomleb reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some comments 👍

pkg/ext/delegate_test.go Outdated Show resolved Hide resolved
pkg/ext/delegate_error.go Outdated Show resolved Hide resolved
tomleb
tomleb reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the apierror assertion.

pkg/ext/delegate_error_test.go Outdated Show resolved Hide resolved
pkg/ext/delegate_error_test.go Outdated Show resolved Hide resolved
pkg/ext/delegate_error_test.go Outdated Show resolved Hide resolved
pkg/ext/delegate_error_test.go Outdated Show resolved Hide resolved
pkg/ext/delegate_error_test.go Outdated Show resolved Hide resolved
pkg/ext/delegate_error_test.go Outdated Show resolved Hide resolved
ericpromislow
ericpromislow approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gehrkefc gehrkefc merged commit ea17719 into main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomleb tomleb tomleb approved these changes

@ericpromislow ericpromislow ericpromislow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gehrkefc @ericpromislow @tomleb