Skip to content

Commit

Permalink
fix(kustomize): Deploy latest system-upgrade-controller
Browse files Browse the repository at this point in the history 
Before this patch always version v0.8.0 would be deployed when using the
kustomize command from the README. This patch adjust the kustomization
to not overwrite the version.

The build process is unaffected from this, since during the build script
the kustomize file is adjusted to adjust the version to the current
release. This means the build manifests for release will still have a
pinned version like before.

Reference:
https://github.com/rancher/system-upgrade-controller/blob/4eacc2dabbde943ee59dc7819ea0a04909b05b0f/scripts/package-controller#L36
  • Loading branch information
@SISheogorath @brandond
SISheogorath authored and brandond committed Mar 8, 2024
1 parent db86e24 commit 4e31e5d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions kustomization.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,3 @@ resources:
- manifests/clusterrole.yaml
- manifests/clusterrolebinding.yaml
- manifests/system-upgrade-controller.yaml
images:
- name: rancher/system-upgrade-controller
newTag: v0.8.0
2 changes: 1 addition & 1 deletion manifests/system-upgrade-controller.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ spec:
effect: "NoExecute"
containers:
- name: system-upgrade-controller
image: rancher/system-upgrade-controller:v0.11.0
image: rancher/system-upgrade-controller:latest

This comment has been minimized.

Sign in to view

Copy link
@emmorts

emmorts Mar 8, 2024

latest tag does not exist in Docker Hub - https://hub.docker.com/r/rancher/system-upgrade-controller/tags

This comment has been minimized.

Sign in to view

Copy link
@brandond

brandond Mar 8, 2024

Member

right, @SISheogorath I think we do need to continue to adjust the version in the kustomization.yaml, and make sure that the newTag is bumped as part of the release process. This happens automatically as part of CI for release artifacts, but anyone trying to use kustomize to apply from the manifests checked into the repo will run into problems, as we do not publish a latest tag on Docker Hub.

This comment has been minimized.

Sign in to view

Copy link
@SISheogorath

SISheogorath Mar 9, 2024

Author Contributor

Can't we start to push a latest version? Since the controller manages its own CRDs anyway, you won't have a controller that is incompatible with the CRD if you stick with latest.

This comment has been minimized.

Sign in to view

Copy link
@brandond

brandond Mar 12, 2024

Member

we do not generally do latest tags for our projects, since it's considered somewhat of an anti-pattern, but we could consider doing so I guess.
imagePullPolicy: IfNotPresent
securityContext:
runAsNonRoot: true
Expand Down

0 comments on commit 4e31e5d

Please sign in to comment.