Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker 24.0.x support #5136

Merged

Conversation

rak-phillip
Copy link
Member

fixes rancher/dashboard#10806

This PR adds Docker 24.0.x support - so when 24 is added, this will come from the backend as the default version and will be added to the list. Docker 24 is currently the default, so adding 24 here will ensure that when it is no longer the default, it will continue to be listed.

Code added in the previous release ensures that if a hard-code entry in the list is also the default, it will only be shown once.

@rak-phillip rak-phillip added this to the v2.9.0 milestone Apr 18, 2024
@rak-phillip rak-phillip self-assigned this Apr 18, 2024
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip merged commit a9ca59c into rancher:master Apr 18, 2024
2 checks passed
@rak-phillip
Copy link
Member Author

/backport v2.8.next1 release-2.8

@richard-cox
Copy link
Member

richard-cox commented Apr 19, 2024

@rak-phillip @mantis-toboggan-md to confirm only 24.0.x is needed and not the referenced 25.0.x in the issue? if so can the original issue be updated?

Edit: worth mentioning rancher/dashboard#10841 just came in too

@rak-phillip
Copy link
Member Author

rak-phillip commented Apr 19, 2024

@rak-phillip @mantis-toboggan-md to confirm only 24.0.x is needed and not the referenced 25.0.x in the issue?

@richard-cox Yes. When a version n of the docker install is published, UI fetches that version from the backend; it is added to the list as the default. From what I could tell, our role has been to add version n-1 to the list to serve as a cache so it does not get lost after a new version is published.

if so can the original issue be updated?

Absolutely, we'll add some context over there.

@richard-cox
Copy link
Member

More weirdness, as always @rak-phillip thanks for your explanation and patience. Feels like we should be generating these automatically backwards from the provided one (if that is guaranteed to be latest). Can you create a tech debt issue, maybe just generally about removing the need to add entries manually?

@rak-phillip
Copy link
Member Author

@richard-cox We created rancher/dashboard#10849 to see if we can address this moving forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "v25.0.x" option for "Docker Install URL" dropdown for RKE1
3 participants