Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure cloud provider option based on k8s version support #5160

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Aug 6, 2024

Fixes rancher/dashboard#11520

Occurred changes

  • Azure is removed from the list of cloud providers when k8s version is >= 1.30
  • When selected k8s version is >=1.27 or < 1.30 the Azure option will be displayed
  • While the supported version is selected If you change that to an unsupported version External option automatically gets selected and a warning banner will be displayed that includes a documentation link
  • By switching to a different cloud provider or a supported k8s version the warning banner will disappear
Screen.Recording.2024-08-07.at.11.26.28.AM.mov

What should be tested

  • Watch the video and test the same scenarios
  • Also try to finish creating an Azure RKE1 cluster, I did not test that in my video, and there was an issue that got fixed later

@momesgin momesgin added this to the v2.10.0 milestone Aug 6, 2024
@momesgin momesgin self-assigned this Aug 6, 2024
@momesgin momesgin marked this pull request as ready for review August 7, 2024 18:33
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@momesgin momesgin merged commit 30e2cec into rancher:master Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes for Azure cloud provider for RKE1
2 participants