implement auto upgrades of wins.exe via the SUC image #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisonWAffel
force-pushed
the
auto-upgrades
branch
from
98c2610 to
681f0b3
Compare
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: rancher/rancher#47652
Problem
The
rancher-winssystem-upgrade-controller image does not automatically upgrade thewins.exebinary on the host. This forces users to reprovision Windows nodes in order to obtain the latest version of thesystem-agentandrancher-wins, and has resulted in unnecessary changes in Rancher to handle behavior differences between different versions ofrancher-wins.Solution
This PR introduces a new
hostpackage which embeds the latest version ofwins.exeinto the SUC image during compilation. When the SUC image runs, it will compare the version of wins installed onto the host (by invokingc:\Windows\wins.exe --version) and, if needed, write the embedded version to disk into the required directories (c:\Windows&c:\usr\local\bin).This behavior can be disabled by setting the
CATTLE_WINS_SKIP_BINARY_UPGRADEenvironment variable totrue. This is required when running CI tests which do not fully installrancher-wins.CI has been updated to cover this behavior during PRs and releases, ensuring that the proper version of
wins.exeis always embedded into the SUC binary. Additionally, existing tests have been adjusted to ensure that we are tracking the proper exit code of certain commands.Extra Context
This PR does not handle automatic upgrades of the csiproxy. Additional investigation needs to be done regarding this component.