Use indexer when listing cached types by hash #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
changed the title
moio
reviewed
Nov 23, 2023
KevinJoiner
approved these changes
Dec 14, 2023
pkg/apply/desiredset_process_test.go
Outdated
| @@ -109,3 +113,157 @@ func Test_multiNamespaceList(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func Test_canIndexByHash(t *testing.T) { | |||
There was a problem hiding this comment.
There is nothing to change here; it's just a suggestion for future tests. We would get a lot of mileage by having one test function for the entire list(...) function since we can better verify the desired interaction with the current behavior.
aruiz14
force-pushed
the
hash-indexer
branch
2 times, most recently
from
d137c74 to
c3044b9
Compare
|
@KevinJoiner I had to upgrade the |
KevinJoiner
approved these changes
Dec 14, 2023
aruiz14
force-pushed
the
hash-indexer
branch
from
16a4fb8 to
77c0d98
Compare
Done! Thanks for your review! |
moio
approved these changes
Dec 18, 2023
|
@KevinJoiner I see I cannot merge this, can you help? |
moio
approved these changes
Dec 18, 2023
aruiz14
added a commit
to aruiz14/wrangler
that referenced
this pull request
Jan 3, 2024
aruiz14
added a commit
to aruiz14/wrangler
that referenced
this pull request
Jan 5, 2024
* Add indexer by hash for cached types * Upgrade golangci-lint GitHub action, since it always fails now
aruiz14
added a commit
to aruiz14/wrangler
that referenced
this pull request
Jan 9, 2024
aruiz14
added a commit
to aruiz14/wrangler
that referenced
this pull request
Jan 10, 2024
* Add indexer by hash for cached types * Upgrade golangci-lint GitHub action, since it always fails now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to rancher/fleet#1842
Extending
WithCacheTypeoption, those types will be indexed by their hash label (objectset.rio.cattle.io/hash), which every object produced or modified byApplyhas. This is a direct replacement for usingListwith an exact label selector, which is certainly more expensive.The ultimate goal of this change is reducing CPU usage, which has been successfully observed by testing this change in a custom Fleet build (along with rancher/fleet#1857), where in some cases produced around 40%-50% CPU drop (see SURE-6990).