Create bmsad per item and reuse them instead of creating a bmsad for each location #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanatosGit
force-pushed
the
bmsad-per-item
branch
from
f71398d to
02651f4
Compare
dyceron
approved these changes
Nov 23, 2023
ThanatosGit
commented
Nov 23, 2023
| editor.add_new_asset("actors/items/randomizer_powerup/scripts/randomizer_powerup.lc", b'', lua_pkgs(all_pkgs)) | ||
| # FIXME: Why it doesn't work when we directly add it to the pkgs? | ||
| # Addition: Tested => It seems like this file is read fro RomFS but why not from pkg? | ||
| editor.add_new_asset("actors/items/randomizer_powerup/scripts/randomizer_powerup.lc", b'', []) |
There was a problem hiding this comment.
This still looks a little bit weird but some lua files were not read from pkg files, so I decided to not add our own files to the pkgs at all.
dyceron
reviewed
Nov 23, 2023
| else: | ||
| bmsad["components"].pop("FX") |
There was a problem hiding this comment.
I wonder if we could add this here too bmsad["sound_fx"] = ListContainer([])
There was a problem hiding this comment.
In vanilla that's the case for majors iirc. Minors (at least missile tanks) have the stuff in there which is in our template_bmsad.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably much better in memory consumption to use one bmsad per item instead of per location. That's reducing the required custom bmsads by something like over 100 files.
(Should be rebased later. Accidentally, have the chozo seal dna stuff in here)