Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom heatzone.lua #519

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Remove custom heatzone.lua #519

merged 2 commits into from
Jan 27, 2025

Conversation

dyceron
Copy link
Collaborator

@dyceron dyceron commented Jan 27, 2025

By reverting the heat sound change function in #517, the custom heatzone.lua is now a duplicate of the original one and can be removed, as it does nothing.

Also adds a default case to RandoApi.CheckSuits() in case we want to be able to remove suits to properly update the suit model.

@dyceron dyceron requested a review from ThanatosGit January 27, 2025 04:45
@ThanatosGit
Copy link
Collaborator

Also adds a default case to RandoApi.CheckSuits() in case we want to be able to remove suits to properly update the suit model.

Hmm that would require to deal with the liquid stuff, so I don't really see a reason to add this now but also doesn't do any harm.

@ThanatosGit ThanatosGit merged commit 767b8c0 into main Jan 27, 2025
7 checks passed
@dyceron dyceron deleted the remove-heatzone.lua branch January 31, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants