Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSR - Remove old guides and add new one #101

Merged
merged 9 commits into from
Nov 1, 2024
Merged

MSR - Remove old guides and add new one #101

merged 9 commits into from
Nov 1, 2024

Conversation

dyceron
Copy link
Contributor

@dyceron dyceron commented Oct 25, 2024

Removes the romfs and exheader guides and adds a new one on getting a decrypted file with godmode9

Fixes #100

@dyceron dyceron requested review from duncathan and Miepee October 25, 2024 22:52
@dyceron dyceron requested a review from Miepee October 25, 2024 23:13
@dyceron
Copy link
Contributor Author

dyceron commented Oct 25, 2024

Addressed comments

@dyceron dyceron requested review from Miepee and ThanatosGit October 25, 2024 23:21
_posts/samus_returns/2024-10-25-decrypted-copy.md Outdated Show resolved Hide resolved
assets/guides/godmode9/godmode9-cart-1.png Outdated Show resolved Hide resolved
@dyceron dyceron requested a review from ThanatosGit October 27, 2024 12:44
@dyceron
Copy link
Contributor Author

dyceron commented Oct 27, 2024

Addressed all comments. The guide now only shows the recommended methods (.3ds for cart, .cxi for digital).

@dyceron dyceron requested a review from Miepee October 27, 2024 13:13
Copy link
Contributor

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Fixes #100

Copy link
Contributor

@duncathan duncathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than deleting the old guides, remove their samus_returns tags to hide them from the list, add noindex: true to their front matter, and add a few sentences at the top of each one indicating that they're for RDV 8.5.0 or earlier and linking to the new guide for more recent versions. that way existing links to these guides won't get broken and people will retain access to the information they need for whichever version they're playing

@dyceron dyceron requested a review from duncathan October 30, 2024 00:00
@dyceron
Copy link
Contributor Author

dyceron commented Oct 30, 2024

I re-added the older guides and moved the pictures to their own folder.

Copy link
Contributor

@duncathan duncathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be merged as soon as we make the new release

Copy link
Contributor

@Miepee Miepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either I'm dumb, or I can't find a way to merge without an approval, so here's one.

@Miepee Miepee merged commit 1e452d3 into main Nov 1, 2024
1 check passed
@Miepee Miepee deleted the msr-new-guide branch November 1, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MSR guides
4 participants