Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xlsx-validator to travis build matrix #520

Open
wants to merge 2 commits into
base: release-3.0.0
Choose a base branch
from

Conversation

vindvaki
Copy link

@vindvaki vindvaki commented Apr 1, 2017

As promised in #501 (comment)

This adds a run of xlsx-validator on the files generated by examples/example.rb to the travis build matrix. You can see it in action on travis for my fork

These same steps can be used to run the validator locally as long as you have docker installed.

@vindvaki vindvaki force-pushed the release-3.0.0-with-xlsx-validator-ci branch from 18263b4 to 1c802d0 Compare April 1, 2017 16:57
@vindvaki
Copy link
Author

vindvaki commented Apr 1, 2017

Oh and I guess your travis also uses the config from this PR for the build

@vindvaki
Copy link
Author

Turns out the validator does not catch any of the corruption errors of current master, which is a bummer. So the added value seems pretty marginal.

@vindvaki
Copy link
Author

Actually, it catches <a:round/>, paperHeight, and paperWidth, all of which caused trouble with Excel 2007. But it's also quite noisy:

  • here are some issues that don't cause a corrupt document prompt in excel
  • the main:sz error might be a false positive
  • if the examples were split into smaller files it would be easier to pinpoint issues with individual features

@vindvaki vindvaki mentioned this pull request May 9, 2017
@vindvaki
Copy link
Author

vindvaki commented May 9, 2017

@randym Could you please take a look? I've allowed failures for the validator build step, like you mentioned in #501.

@noniq
Copy link
Collaborator

noniq commented Dec 20, 2019

@vindvaki This looks like a promising feature. If you’re still interested in getting this merged, please reopen this PR in https://github.com/caxlsx/caxlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants