-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul AutoLayout Alignment property #95
base: main
Are you sure you want to change the base?
Conversation
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
Demo App Preview: https://d11mwnosflssyy.cloudfront.net/ |
Code Coverage ReportCoverage after merging AutoLayout-alignment-overhaul into main
Coverage Report
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 05b2c34. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
3beeb3c
to
05b2c34
Compare
🚧 Work In Progress 🚧
TODO
align-items
andjustify-content
properties), this presents a problem. For the time being I've just added an escape where the alignment property isn't actually computed if passed anything buthorizontal
orvertical
, which obviously is not a good long-term solution.library/foundations/generated/design-tokens.constants.ts
, but containing values. From this we can compute the appropriate styles at each breakpoint... but this would require listening to the browser size.alignment
property has been used to make sure they are working correctly with the new schemaScreenshots