Add optional TAN medium field to constructor of FinTS3PinTanClient (fix #121, #106) #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in my comment on #121, this pull request is a tiny hotfix which allows users to manually set a TAN medium when initializing a new FinTS3PinTanClient. Ideally, we would build a better solution that automatically requests TAN media and sets it directly if there is only one available (I suspect this is the case for the vast majority of users). Nonetheless, this is a very quick and dirty fix to at least allow library users to control the TAN medium manually and avoid errors on initialization.
This fixes issues #121 and #106.