[3.x] GraphQL checkout #503
Conversation
Merge master in graphql-checkout
|
Merged, feedback is still appreciated. Maybe @Jade-GG or @BobWez98? Internal reference RAP-980 was created to process possible feedback on this. But with this we can proceed with other things depending on this. While reviewing; think about upgrading and keep an eye on the upgrade guide: https://docs.rapidez.io/3.x/upgrading.html |
| /resources/views/cart/queries/*.graphql | ||
| /resources/views/cart/queries/**/*.graphql | ||
| /resources/views/checkout/queries/*.graphql | ||
| /resources/views/checkout/queries/**/*.graphql | ||
| /resources/views/customer/queries/*.graphql | ||
| /resources/views/customer/queries/**/*.graphql |
There was a problem hiding this comment.
Just one line isn't possible?
| @@ -0,0 +1,156 @@ | |||
| fragment cart on Cart { | |||
| id | |||
| # TODO: Check if virtual orders are working | |||
There was a problem hiding this comment.
This is checked and can be removed?
|
|
||
| <div v-if="cart.shipping_addresses[0]" class="flex w-full flex-col gap-x-1 border p-3 rounded"> | ||
| <p class="font-lg mb-2 font-bold text-neutral"> | ||
| {{-- TODO: Check this compare as uid might not what we want but there is not anything else in the cart response --}} |
There was a problem hiding this comment.
Do we need to do something with this?
| @if (!$checkoutAgreements->count()) | ||
| @return | ||
| @endif |
There was a problem hiding this comment.
We can change this with rapidez/blade-directives#17 and bump the version to 0.7.0
| :callback="handlePlaceOrder" | ||
| mutate-event="placeOrder" | ||
| redirect="{{ route('checkout.success') }}" | ||
| {{-- :error-callback="alert" --}} |
There was a problem hiding this comment.
Errors are already handled?
|
Don't forget the older unresolved conversations |
customer?.idwill no longer be available.This can be replaced with Rapidez' loggedIn property.
If backwards compatibility is not a factor,
user.is_logged_incan be usedany
config.queries.cartor@include('rapidez::cart.queries.cart')need to be moved as the graphql file has been changed to a fragment.The newly added auth guard for the cart can be used to ensure someone has an active cart:
middleware('auth:magento-cart')Both token and mask have been moved into cookies, it is now possible to use
middleware('auth:magento-cart')andmiddleware('auth:magento-customer')on web routes.Removed hasOnlyVirtualItems from cart, use cart.is_virtual instead.
Removed VirtualItems from cart, as this was only used to determine hasOnlyVirtualItems.
InteractWithUser has been removed, use the
stores/useUserinsteadSupport dropped for Laravel 10
Support dropped for Magento <2.4.7