Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add latest branch build option to *test.yaml workflows #147

Open
18 of 19 tasks
gforsyth opened this issue Feb 3, 2025 · 1 comment
Open
18 of 19 tasks

Add latest branch build option to *test.yaml workflows #147

gforsyth opened this issue Feb 3, 2025 · 1 comment
Assignees
@gforsyth

Comments

@gforsyth
Copy link

gforsyth commented Feb 3, 2025 •
edited
Loading

xref: rapidsai/gha-tools#138

@vyasr laid this out in the issue above:

Currently all our test CI jobs use rapids-download-*-from-s3 to get their artifacts (cudf example). These tools all call rapids-download-from-s3, which in turn calls rapids-s3-path. Since rapids-s3-path constructs its path based on the build type, that implicitly means that test.yaml always pulls the build from the corresponding nightly build, even if there was a more recent branch build. This is particularly problematic in light of #127 since it is now more important to be able to resolve these failures within a given day i.e. by rerunning the test workflow on a branch build. To support this use case, we should make the build type an optional input to the test.yaml workflow to customize which type of build to pull in the workflow. This will allow us to customize running a test workflow on a branch build to unblock CI once fixes are in.

I'm opening this to track the work and so we don't have the tracking over in gha-tools

Tasks
Preview Give feedback

Once I merge in the above, then, for the repos below, once they are targeting
[email protected] I can begin adding in the option for running against a
particular branch.

Tasks
Preview Give feedback
gforsyth added a commit to gforsyth/cudf that referenced this issue Feb 3, 2025
@gforsyth
Add build_type input to workflow inputs
31922a1 
xref: rapidsai/build-planning#147
@gforsyth gforsyth mentioned this issue Feb 3, 2025
Closed
3 tasks
@bdice bdice mentioned this issue Feb 3, 2025
Merged
3 tasks
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this issue Feb 3, 2025
@gforsyth
Add build_type to workflow inputs (#1811)
fe66a24 
xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #1811
@gforsyth gforsyth self-assigned this Feb 5, 2025
@gforsyth gforsyth mentioned this issue Feb 5, 2025
Merged
@gforsyth
Copy link
Author

gforsyth commented Feb 5, 2025

xref rapidsai/shared-workflows#276

This was referenced Feb 5, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/nx-cugraph that referenced this issue Feb 5, 2025
@gforsyth
Add build_type input field for test.yaml (#82)
9195add 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #82
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#6296)
0facc22 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #6296
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#766)
935ecd3 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #766
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#17925)
4323ae4 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

supercedes #17906

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #17925
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#4918)
e999f15 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #4918
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#661)
7fe75b8 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #661
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#1115)
82a7a1b 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #1115
rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#367)
84982e3 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #367
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#2573)
ac82745 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #2573
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#620)
6b1a71f 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #620
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this issue Feb 6, 2025
@gforsyth
Add build_type input field for test.yaml (#1444)
a1524e7 
Exposes `build_type` as an input in `test.yaml` so that `test.yaml` can be
manually run against a specific branch/commit as needed.

The default value is still `nightly`, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

Authors:
  - Gil Forsyth (https://github.com/gforsyth)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #1444
@gforsyth gforsyth mentioned this issue Feb 11, 2025
Open
This was referenced Feb 11, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gforsyth gforsyth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gforsyth