Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build_type input field for test.yaml #661

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Add build_type input field for test.yaml #661

merged 1 commit into from
Feb 6, 2025
+7 −4

Conversation

gforsyth
Copy link
Contributor

@gforsyth gforsyth commented Feb 5, 2025

Exposes build_type as an input in test.yaml so that test.yaml can be
manually run against a specific branch/commit as needed.

The default value is still nightly, and without maintainer intervention, that
is what will run each night.

xref rapidsai/build-planning#147

@gforsyth gforsyth added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 5, 2025
@gforsyth gforsyth requested review from a team as code owners February 5, 2025 19:53
@gforsyth gforsyth requested a review from raydouglass February 5, 2025 19:53
@gforsyth gforsyth mentioned this pull request Feb 5, 2025
Open
@gforsyth gforsyth changed the base branch from branch-25.02 to branch-25.04 February 5, 2025 19:56
jameslamb
jameslamb approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the title to "Add build_type input field for test.yaml" to match the other PRs from this issue?

That PR title will become a commit message when this is squash-merged.

@jameslamb jameslamb removed request for a team and raydouglass February 5, 2025 20:19
@gforsyth gforsyth changed the title testyaml build type Add build_type input field for test.yaml Feb 5, 2025
@gforsyth
Copy link
Contributor Author

gforsyth commented Feb 5, 2025

Can you change the title to "Add build_type input field for test.yaml" to match the other PRs from this issue?

Done! Not sure how that happened -- must've hit something weird on the command line. Thanks for catching it!

@jameslamb
Copy link
Member

jameslamb commented Feb 5, 2025 •
edited
Loading

No prob! Seeing that + all the extraneous codeowners groups, I'm guessing that maybe this was originally targeted at branch-25.02 and then retargeted. When a PR branch has more than 1 commit different from the target branch, GitHub fills in a de-sluggified (word?) form of the branch name as the title.

@gforsyth
Copy link
Contributor Author

gforsyth commented Feb 6, 2025

/merge

@rapids-bot rapids-bot bot merged commit 7fe75b8 into rapidsai:branch-25.04 Feb 6, 2025
63 checks passed
@gforsyth gforsyth deleted the testyaml_build_type branch February 6, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
ci CMake improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gforsyth @jameslamb @cjnolet