Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CUDA 12.8.0. #231

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Update to CUDA 12.8.0. #231

merged 2 commits into from
Jan 27, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 23, 2025

Adds CUDA 12.8.0 CI images.

This depends on nvidia/cuda images being available.

@bdice
Copy link
Contributor Author

bdice commented Jan 24, 2025

Hopefully we can file a follow-up PR to drop one of 12.2.2 or 12.5.1 from our CI images. Perhaps we can drop 12.2.2 and keep 12.5.1 as our "middle" CUDA 12 version used for testing?

@jameslamb
Copy link
Member

Perhaps we can drop 12.2.2 and keep 12.5.1 as our "middle" CUDA 12 version used for testing?

I don't have any specific information to add to help with this decision, but keeping 12.5.1 and dropping 12.2.2 sounds fine to me. I do agree it'd be good to drop one of them from the test matrix, to get denser coverage of 12.8.

@bdice
Copy link
Contributor Author

bdice commented Jan 24, 2025

A bit more context on why I am proposing to keep 12.5 and drop 12.2:

We have a limited amount of CI jobs that we can run. We try to keep dense coverage on the endpoints, like "newest" and "oldest". Historically we have not had a lot of guidance or requirements on which "latest major, middle minor" version to test, and we only use 12.2 at present because that was our "newest" version until we migrated to 12.5. We don't have enough CI resources to keep both 12.2 and 12.5, so I would again favor keeping a more recent version.

@jakirkham
Copy link
Member

There were a few features that were added in CUDA 12.2 that were not available in previous versions, which motivates testing it

Have glanced through the release notes between there and here as well as RAPIDS source. Not seeing anything as compelling for RAPIDS feature-wise as 12.2

So would actually suggest we keep 12.2 since it is a useful lower bound and drop 12.5 in favor of 12.8

@vyasr
Copy link
Contributor

vyasr commented Jan 25, 2025

I think those are pretty good reasons to prefer 12.2 to 12.5.

@bdice
Copy link
Contributor Author

bdice commented Jan 27, 2025

nvidia/cuda images are now live. I will rerun CI.

@bdice bdice marked this pull request as ready for review January 27, 2025 20:06
@bdice bdice requested a review from a team as a code owner January 27, 2025 20:06
@bdice bdice requested review from AyodeAwe and removed request for a team January 27, 2025 20:06
@bdice bdice mentioned this pull request Jan 27, 2025
@bdice
Copy link
Contributor Author

bdice commented Jan 27, 2025

I opened #232 to capture our intentions around dropping CUDA 12.5 images. We should do that before the 25.04 release, to ensure continuity in our CI image availability.

@bdice bdice merged commit 39ec217 into rapidsai:main Jan 27, 2025
523 of 524 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants