-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CUDA 12.8.0. #231
Conversation
Hopefully we can file a follow-up PR to drop one of |
I don't have any specific information to add to help with this decision, but keeping 12.5.1 and dropping 12.2.2 sounds fine to me. I do agree it'd be good to drop one of them from the test matrix, to get denser coverage of 12.8. |
A bit more context on why I am proposing to keep 12.5 and drop 12.2: We have a limited amount of CI jobs that we can run. We try to keep dense coverage on the endpoints, like "newest" and "oldest". Historically we have not had a lot of guidance or requirements on which "latest major, middle minor" version to test, and we only use 12.2 at present because that was our "newest" version until we migrated to 12.5. We don't have enough CI resources to keep both 12.2 and 12.5, so I would again favor keeping a more recent version. |
There were a few features that were added in CUDA 12.2 that were not available in previous versions, which motivates testing it
Have glanced through the release notes between there and here as well as RAPIDS source. Not seeing anything as compelling for RAPIDS feature-wise as 12.2 So would actually suggest we keep 12.2 since it is a useful lower bound and drop 12.5 in favor of 12.8 |
I think those are pretty good reasons to prefer 12.2 to 12.5. |
|
I opened #232 to capture our intentions around dropping CUDA 12.5 images. We should do that before the 25.04 release, to ensure continuity in our CI image availability. |
Thanks all! 🙏 |
Adds CUDA 12.8.0 CI images.
This depends on
nvidia/cuda
images being available.