Add dispatch for cudf.Dataframe to/from pyarrow.Table conversion
#13558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
2 - In Progress
rjzamora
added
helps: Dask
improvement
rjzamora
commented
Jun 13, 2023
Comment on lines
+394
to
+399
| kwargs.pop("self_destruct", None) | ||
| if kwargs: | ||
| warnings.warn( | ||
| f"Ignoring the following arguments to " | ||
| f"`from_pyarrow_table_dispatch`: {list(kwargs)}" | ||
| ) |
There was a problem hiding this comment.
Note that self_destruct is currently the only argument "needed" by the p2p algorithm (for pandas backed data). However, cudf.DataFrame.from_arrow doesn't take this (or any other) key-word argument.
Since I expect a bit of iteration on exactly which key-word arguments these dispatch functions will need to support, I am temporarily using kwargs and warning the user if an unexpected argument is encountered. I'd prefer for these functions to not raise an error until we have time to nail down the exact API we need.
rjzamora
added
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Registers the necessary cudf-specific logic for the dispatch functions introduced in dask/dask#10312. These dispatch functions are necessary to enable "p2p" shuffling with a cudf backend (see: dask/distributed#7743)
Checklist