Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ToCudfBackend expression to dask-cudf #16573

Merged
merged 8 commits into from
Aug 19, 2024
Merged

Add ToCudfBackend expression to dask-cudf #16573

merged 8 commits into from
Aug 19, 2024

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Aug 15, 2024 •
edited
Loading

Description

Adds a ToCudfBackend expression for "pandas" to "cudf" conversion, preventing to_backend("cudf") operations from blocking useful optimizations like predicate pushdown.

This is the dask-cudf component of dask/dask-expr#1115

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added 2 - In Progress Currently a work in progress dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 15, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 15, 2024
@rjzamora rjzamora marked this pull request as ready for review August 16, 2024 14:16
@rjzamora rjzamora requested a review from a team as a code owner August 16, 2024 14:16
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 16, 2024
madsbk
madsbk approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thansk @rjzamora

@rjzamora rjzamora self-assigned this Aug 19, 2024
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 19, 2024
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 1b18cbc into rapidsai:branch-24.10 Aug 19, 2024
79 checks passed
@rjzamora rjzamora deleted the to-backend branch August 19, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees

@rjzamora rjzamora

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjzamora @madsbk