[FEA] Report all unsupported operations for a query in cudf.polars #16960

Matt711 · 2024-10-01T02:05:29Z

Description

Closes #16690. The purpose of this PR is to list all of the unique operations that are unsupported by cudf.polars when running a query.

Question: How to traverse the tree to report the error nodes? Should this be done upstream in Polars?
Instead of traversing the query afterwards, we should probably catch each unsupported feature as we translate the IR.

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

python/cudf_polars/cudf_polars/dsl/ir.py

python/cudf_polars/cudf_polars/utils/other.py

python/cudf_polars/cudf_polars/dsl/translate.py

python/cudf_polars/cudf_polars/callback.py

python/cudf_polars/cudf_polars/dsl/translate.py

wence-

Thanks, this is looking really nice. Some smaller suggestions and a few small logic fixes

python/cudf_polars/cudf_polars/dsl/translate.py

python/cudf_polars/cudf_polars/callback.py

python/cudf_polars/tests/test_translate_in_debug_mode.py

python/cudf_polars/cudf_polars/callback.py

wence-

Tiny suggestions, debug_mode is now gone.

python/cudf_polars/cudf_polars/dsl/translate.py

Matt711

I changed the logic of assert_ir_translation_raises to integrate with the changes made in this PR. I made the changes because now that we're returning ErrorNodes and ErrorExprs instead of raising exceptions during translation, assert_ir_translation_raises(q, NotImplementedError) fails in a lot of places.

To solve this, I checked that the exception(s) being asserted in q.collect(...) are inside Translation.errors and treated any other exceptions raised during translation as cases where assert_ir_translation_raises fails. I this required me to hard-code a few cases where translation could fail.

Are there other cases I missed where translation could fail? WDYT of the changes @wence-?

python/cudf_polars/tests/test_config.py

python/cudf_polars/cudf_polars/testing/asserts.py

python/cudf_polars/cudf_polars/dsl/translate.py

python/cudf_polars/cudf_polars/testing/asserts.py

wence- · 2024-10-30T17:19:34Z

@Matt711 This stalled a bit, I think it's a good one to get into 24.12, do you need some help with some bits?

Matt711 · 2024-10-31T00:39:24Z

@Matt711 This stalled a bit, I think it's a good one to get into 24.12, do you need some help with some bits?

Hey @wence-, that should be doable. The last thing I needed to do with this PR is get test coverage to 100%. I'll address merge conflicts tomorrow, and try to do that too. I'll check in offline if I need help.

copy-pr-bot · 2024-10-31T15:02:51Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Matt711 · 2024-10-31T19:01:19Z

/ok to test

Matt711 · 2024-10-31T21:21:10Z

/ok to test

Matt711 · 2024-11-01T00:25:17Z

/ok to test

Matt711 · 2024-11-01T13:24:34Z

/ok to test

Matt711 · 2024-11-01T15:45:47Z

/ok to test

Matt711 · 2024-11-01T16:44:57Z

python/cudf_polars/cudf_polars/testing/plugin.py

@@ -45,6 +45,7 @@ def pytest_configure(config: pytest.Config) -> None:


 EXPECTED_FAILURES: Mapping[str, str] = {
+    "tests/unit/dataframe/test_df.py::test_extension": "AssertionError",


I could use some help understanding why this test is failing. It fails at the first ref count assertion. The test is here https://github.com/pola-rs/polars/blob/40f8f5d63c225cd3dcb4e220db1bd5622274b2ab/py-polars/tests/unit/dataframe/test_df.py#L1820
@wence-

Does it fail for you on branch-24.12, I guess not?

No idea, sorry

python/cudf_polars/cudf_polars/dsl/translate.py

Matt711 · 2024-11-01T17:26:22Z

I'm opening this PR up for reviews now that tests are passing. One of the polars tests is failing and I need some helping debugging it.

Edit: I'll address merge conflicts once this PR is ready.

python/cudf_polars/cudf_polars/dsl/translate.py

wence-

Looks good @Matt711, I had one suggestion that may help your segfault issue

python/cudf_polars/cudf_polars/callback.py

wence- · 2024-11-05T16:58:59Z

python/cudf_polars/cudf_polars/dsl/translate.py

+                node = self.visitor.view_current_node()
+            except Exception as e:
+                self.errors.append(e)
+                return ir.ErrorNode({}, str(e))


I think this one wants to use the schema we generate in the lines below. That way we won't get any false positive "schema mismatch" errors later in translation.

Suggested change

return ir.ErrorNode({}, str(e))

return ir.ErrorNode(schema, str(e))

That schema is defined after this point.

wence- · 2024-11-05T16:59:28Z

python/cudf_polars/cudf_polars/dsl/translate.py

+                schema = {k: dtypes.from_polars(v) for k, v in polars_schema.items()}
+            except Exception as e:
+                self.errors.append(e)
+                return ir.ErrorNode({}, str(e))


Hmm, a tricky one, we want to put schema here, but we didn't manage to make it.

python/cudf_polars/cudf_polars/dsl/translate.py

python/cudf_polars/cudf_polars/testing/asserts.py

wence- · 2024-11-05T17:12:11Z

python/cudf_polars/cudf_polars/testing/plugin.py

@@ -45,6 +45,7 @@ def pytest_configure(config: pytest.Config) -> None:


 EXPECTED_FAILURES: Mapping[str, str] = {
+    "tests/unit/dataframe/test_df.py::test_extension": "AssertionError",


No idea, sorry

…ed-ops

Matt711 · 2024-11-07T04:23:20Z

/ok to test

Matt711 added feature request New feature or request 5 - DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Oct 1, 2024

Matt711 self-assigned this Oct 1, 2024

github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Oct 1, 2024

wence- reviewed Oct 1, 2024

View reviewed changes

python/cudf_polars/cudf_polars/dsl/ir.py Outdated Show resolved Hide resolved

python/cudf_polars/cudf_polars/utils/other.py Outdated Show resolved Hide resolved

python/cudf_polars/cudf_polars/dsl/translate.py Outdated Show resolved Hide resolved

Matt711 commented Oct 2, 2024

View reviewed changes

python/cudf_polars/cudf_polars/callback.py Outdated Show resolved Hide resolved

wence- requested changes Oct 8, 2024

View reviewed changes

python/cudf_polars/cudf_polars/callback.py Outdated Show resolved Hide resolved

python/cudf_polars/cudf_polars/dsl/translate.py Outdated Show resolved Hide resolved

Matt711 force-pushed the fea/cudf-polars/report-all-unsupported-ops branch from 0310f26 to 3175a7e Compare October 9, 2024 03:46

wence- reviewed Oct 9, 2024

View reviewed changes

python/cudf_polars/cudf_polars/dsl/translate.py Outdated Show resolved Hide resolved

Matt711 force-pushed the fea/cudf-polars/report-all-unsupported-ops branch from 3175a7e to 054b271 Compare October 9, 2024 15:28

wence- reviewed Oct 9, 2024

View reviewed changes

Matt711 commented Oct 9, 2024

View reviewed changes

python/cudf_polars/tests/test_translate_in_debug_mode.py Outdated Show resolved Hide resolved

wence- reviewed Oct 10, 2024

View reviewed changes

python/cudf_polars/cudf_polars/callback.py Outdated Show resolved Hide resolved

wence- reviewed Oct 10, 2024

View reviewed changes

python/cudf_polars/cudf_polars/dsl/translate.py Outdated Show resolved Hide resolved

python/cudf_polars/cudf_polars/dsl/translate.py Outdated Show resolved Hide resolved

python/cudf_polars/cudf_polars/dsl/translate.py Outdated Show resolved Hide resolved

Matt711 mentioned this pull request Oct 10, 2024

[FEA] Display operations unsupported by the GPU in a user-friendly way #17051

Open

Matt711 commented Oct 10, 2024

View reviewed changes

wence- reviewed Oct 11, 2024

View reviewed changes

python/cudf_polars/cudf_polars/testing/asserts.py Outdated Show resolved Hide resolved

Matt711 added 6 commits October 31, 2024 07:56

address review

b74bfa9

add a test

a0f5734

add a test

5a1e85f

address review

192e769

address review and fix failing tests

a67bb8b

get code cooverage to pass

9551c1f

Matt711 force-pushed the fea/cudf-polars/report-all-unsupported-ops branch from ff7f2e1 to 9551c1f Compare October 31, 2024 15:02

more merge conflicts

3b770f9

Matt711 added 2 commits October 31, 2024 14:12

get tests passing

5fd2d6a

more clean up

8745c85

Matt711 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 31, 2024

xfail a test

de92ef4

get test passing

126fd73

Matt711 added 3 commits November 1, 2024 06:42

append to errors then raise

1c14bff

xfail test

d36f39c

fix code converge

293728d

Matt711 commented Nov 1, 2024

View reviewed changes

python/cudf_polars/cudf_polars/dsl/translate.py Show resolved Hide resolved

Matt711 marked this pull request as ready for review November 1, 2024 17:26

Matt711 requested a review from a team as a code owner November 1, 2024 17:26

Matt711 requested review from bdice and mroeschke November 1, 2024 17:26

Matt711 changed the title ~~[WIP] Report all unsupported operations for a query in cudf.polars~~ [FEA] Report all unsupported operations for a query in cudf.polars Nov 1, 2024

Matt711 commented Nov 1, 2024

View reviewed changes

python/cudf_polars/cudf_polars/dsl/translate.py Outdated Show resolved Hide resolved

wence- reviewed Nov 5, 2024

View reviewed changes

Matt711 and others added 4 commits November 6, 2024 10:20

merge conflict

b5d21f4

address review

02697e8

address review

349309a

Merge branch 'branch-24.12' into fea/cudf-polars/report-all-unsupport…

588b21f

…ed-ops

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEA] Report all unsupported operations for a query in cudf.polars #16960

[FEA] Report all unsupported operations for a query in cudf.polars #16960

Matt711 commented Oct 1, 2024 •

edited

Loading

wence- left a comment

wence- left a comment

Matt711 left a comment

wence- commented Oct 30, 2024

Matt711 commented Oct 31, 2024

copy-pr-bot bot commented Oct 31, 2024

Matt711 commented Oct 31, 2024

Matt711 commented Oct 31, 2024

Matt711 commented Nov 1, 2024

Matt711 commented Nov 1, 2024

Matt711 commented Nov 1, 2024

Matt711 Nov 1, 2024 •

edited

Loading

wence- Nov 1, 2024

wence- Nov 5, 2024

Matt711 commented Nov 1, 2024 •

edited

Loading

wence- left a comment

wence- Nov 5, 2024

Matt711 Nov 6, 2024 •

edited

Loading

wence- Nov 5, 2024

wence- Nov 5, 2024

Matt711 commented Nov 7, 2024

		@@ -45,6 +45,7 @@ def pytest_configure(config: pytest.Config) -> None:


		EXPECTED_FAILURES: Mapping[str, str] = {
		"tests/unit/dataframe/test_df.py::test_extension": "AssertionError",

	return ir.ErrorNode({}, str(e))
	return ir.ErrorNode(schema, str(e))

[FEA] Report all unsupported operations for a query in cudf.polars #16960

Are you sure you want to change the base?

[FEA] Report all unsupported operations for a query in cudf.polars #16960

Conversation

Matt711 commented Oct 1, 2024 • edited Loading

Description

Checklist

wence- left a comment

Choose a reason for hiding this comment

wence- left a comment

Choose a reason for hiding this comment

Matt711 left a comment

Choose a reason for hiding this comment

wence- commented Oct 30, 2024

Matt711 commented Oct 31, 2024

copy-pr-bot bot commented Oct 31, 2024

Matt711 commented Oct 31, 2024

Matt711 commented Oct 31, 2024

Matt711 commented Nov 1, 2024

Matt711 commented Nov 1, 2024

Matt711 commented Nov 1, 2024

Matt711 Nov 1, 2024 • edited Loading

Choose a reason for hiding this comment

wence- Nov 1, 2024

Choose a reason for hiding this comment

wence- Nov 5, 2024

Choose a reason for hiding this comment

Matt711 commented Nov 1, 2024 • edited Loading

wence- left a comment

Choose a reason for hiding this comment

wence- Nov 5, 2024

Choose a reason for hiding this comment

Matt711 Nov 6, 2024 • edited Loading

Choose a reason for hiding this comment

wence- Nov 5, 2024

Choose a reason for hiding this comment

wence- Nov 5, 2024

Choose a reason for hiding this comment

Matt711 commented Nov 7, 2024

Matt711 commented Oct 1, 2024 •

edited

Loading

Matt711 Nov 1, 2024 •

edited

Loading

Matt711 commented Nov 1, 2024 •

edited

Loading

Matt711 Nov 6, 2024 •

edited

Loading