Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Make __iter__ a fast-slow attribute of the pd.Series proxy type #17168

Closed
wants to merge 3 commits into from

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 24, 2024

Description

Closes #17165. This PR makes __iter__ a fast-slow attribute of pd.Series by removing the the custom iterator function we were using.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added the bug Something isn't working label Oct 24, 2024
@Matt711 Matt711 self-assigned this Oct 24, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Oct 24, 2024
@Matt711 Matt711 added the non-breaking Non-breaking change label Oct 24, 2024
@Matt711 Matt711 marked this pull request as ready for review October 24, 2024 12:22
@Matt711 Matt711 requested a review from a team as a code owner October 24, 2024 12:22
@vyasr
Copy link
Contributor

vyasr commented Oct 28, 2024

I'd like to hear from @galipremsagar on #14481 before we move forward here.

@galipremsagar
Copy link
Contributor

galipremsagar commented Nov 6, 2024

I'd like to hear from @galipremsagar on #14481 before we move forward here.

After investigating the issue I came up with a fix that properly wraps custom iterator results here: #17251

I have explained why we still have a need for custom_iter in the PR description.

@Matt711
Copy link
Contributor Author

Matt711 commented Nov 6, 2024

I'd like to hear from @galipremsagar on #14481 before we move forward here.

After investigating the issue I came up with a fix that properly wraps custom iterator results here: #17251

I have explained why we still have a need for custom_iter in the PR description.

Thanks! I'll go ahead and close this PR.

@Matt711 Matt711 closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect dtype when iterating over dtypes in cudf.pandas
3 participants