Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gather/scatter benchmarks for strings #17223

Open
wants to merge 8 commits into
base: branch-24.12
Choose a base branch
from
Open

Refactor gather/scatter benchmarks for strings #17223

wants to merge 8 commits into from
+76 −157

Conversation

davidwendt
Copy link
Contributor

Description

Combines the benchmarks/string/copy.cu and benchmarks/string/gather.cpp source files which both had separate gather benchmarks for strings. The result is a new copy.cpp that has both gather and scatter benchmarks. Also changes the default parameters to remove the need to restrict the values.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 31, 2024
@davidwendt davidwendt self-assigned this Oct 31, 2024
@github-actions github-actions bot added the CMake CMake build issue label Oct 31, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 31, 2024
@davidwendt davidwendt marked this pull request as ready for review October 31, 2024 15:49
@davidwendt davidwendt requested a review from a team as a code owner October 31, 2024 15:49
bdice
bdice approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe size_type instead of INT32. If there are reasons to keep INT32, this LGTM.

cpp/benchmarks/string/copy.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/string/copy.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/string/copy.cpp Outdated Show resolved Hide resolved
cpp/benchmarks/string/copy.cpp Outdated Show resolved Hide resolved
PointKernel
PointKernel approved these changes Nov 1, 2024
View reviewed changes
cpp/benchmarks/string/copy.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamarrr lamarrr lamarrr approved these changes

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwendt @bdice @PointKernel @lamarrr @vyasr