Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generating large strings in benchmarks #17224

Open
wants to merge 4 commits into
base: branch-24.12
Choose a base branch
from
Open

Allow generating large strings in benchmarks #17224

wants to merge 4 commits into from

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Oct 31, 2024 •
edited
Loading

Description

Updates the benchmark utility create_random_utf8_string_column to support large strings.
Replaces the hardcoded size_type offsets with the offsetalator and related utilities.

Reference #16948

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 31, 2024
@davidwendt davidwendt self-assigned this Oct 31, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 5, 2024
@davidwendt davidwendt marked this pull request as ready for review November 5, 2024 19:36
@davidwendt davidwendt requested a review from a team as a code owner November 5, 2024 19:36
mhaseeb123
mhaseeb123 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments. LGTM otherwise!

cpp/benchmarks/common/generate_input.cu Show resolved Hide resolved
cpp/benchmarks/common/generate_input.cu Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidwendt @mhaseeb123