Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move strings to date/time types benchmarks to nvbench #17229

Open
wants to merge 5 commits into
base: branch-24.12
Choose a base branch
from
Open

Move strings to date/time types benchmarks to nvbench #17229

wants to merge 5 commits into from
+89 −124

Conversation

davidwendt
Copy link
Contributor

Description

Moves the cpp/benchmarks/string/convert_datetime.cpp and cpp/benchmarks/string/convert_duration.cpp benchmark implementations from google-bench to nvbench.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 31, 2024
@davidwendt davidwendt self-assigned this Oct 31, 2024
@github-actions github-actions bot added the CMake CMake build issue label Oct 31, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 5, 2024
@davidwendt davidwendt marked this pull request as ready for review November 5, 2024 19:37
@davidwendt davidwendt requested a review from a team as a code owner November 5, 2024 19:37
karthikeyann
karthikeyann approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vyasr
Copy link
Contributor

vyasr commented Nov 7, 2024

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

Assignees

@vyasr vyasr

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @vyasr @karthikeyann @vuule