Add write_parquet to pylibcudf #17263
Open
+833
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
mroeschke
commented
Nov 7, 2024
| @pytest.mark.parametrize("max_page_size_bytes", [None, 100]) | ||
| @pytest.mark.parametrize("max_page_size_rows", [None, 1]) | ||
| @pytest.mark.parametrize("max_dictionary_size", [None, 100]) | ||
| def test_write_parquet( |
There was a problem hiding this comment.
- This test already generates 32k tests. Thoughts on if that's OK and if not which parameters are most important to exercise
- So far I'm just asserting that
assert isinstance(result, plc.io.parquet.BufferArrayFromVector). I'm hoping that cudf Python can assert more specifics about the metadata result (given that I'm testing a lot of params here) but happy to assert something stronger if desired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Broken off from #17252 since also replacing cudf Python's
write_parquetusage would have made the PR fairly large.Checklist