-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Numba Config to turn on Pynvjitlink Features #17628
base: branch-25.02
Are you sure you want to change the base?
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
dependencies.yaml
Outdated
@@ -688,7 +688,7 @@ dependencies: | |||
- output_types: [conda, requirements, pyproject] | |||
packages: | |||
- cachetools | |||
- &numba-cuda-dep numba-cuda>=0.0.13,<0.0.18 | |||
- &numba-cuda-dep numba-cuda>=0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to keep an upper bound here. Numba-cuda is not stable yet, afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a suggestion from Bradley, but otherwise LGTM. Thanks @isVoid .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#17359 also has some changes in aggregation.pyx, do we not need those?
I think those changes are to avoid importing any of |
The
But I don't see any warnings output in the CI. Are there any warning suppression in the CI? |
No, you probably just need to scroll up further. There are a set of warnings printed after all the "reading sources" lines in before all of the "writing output" lines. I see them here, but they look odd and completely unrelated to the changes in this PR so I am skeptical of how meaningful they are. I've kicked off a rerun to see if they show up again. |
Description
Numba-cuda 0.0.18+ merged in a new feature and made the old way of patching linker with pynvjitlink's
patch_numba_linker
no longer usable by downstream libraries. The current state of Numba-cuda requires that downstream libraries to enable pynvjitlink features only viaCUDA_ENABLE_PYNVJITLINK
environment variable. A recent PR NVIDIA/numba-cuda#91 makes it so that the features can be turned on by a config variable at runtime.This PR is an integration test with that PR and changing the way how pynvjitlink is enabled in cuDF. It enables cuDF to use Numba-cuda since 0.2.0+ (which contains the config change).
Supercedes #17359
Checklist