Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible overflow in WriteCoalescingCallbackWrapper::TearDown #17642

Merged
merged 7 commits into from
Jan 3, 2025
6 changes: 4 additions & 2 deletions cpp/src/io/fst/agent_dfa.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -308,12 +308,14 @@ class WriteCoalescingCallbackWrapper {
{
__syncthreads();
if constexpr (!DiscardTranslatedOutput) {
for (uint32_t out_char = threadIdx.x; out_char < tile_out_count; out_char += blockDim.x) {
for (thread_index_type out_char = threadIdx.x; out_char < tile_out_count;
out_char += blockDim.x) {
out_it[tile_out_offset + out_char] = temp_storage.compacted_symbols[out_char];
}
}
if constexpr (!DiscardIndexOutput) {
for (uint32_t out_char = threadIdx.x; out_char < tile_out_count; out_char += blockDim.x) {
for (thread_index_type out_char = threadIdx.x; out_char < tile_out_count;
out_char += blockDim.x) {
out_idx_it[tile_out_offset + out_char] =
temp_storage.compacted_offset[out_char] + tile_in_offset;
}
Expand Down
Loading