Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set nvCOMP's pinned memory resource #17658

Draft
wants to merge 2 commits into
base: branch-25.02
Choose a base branch
from
Draft

Set nvCOMP's pinned memory resource #17658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e749f08
untested
vuule Dec 25, 2024
00526ee
Merge branch 'branch-25.02' into nvcomp-pinned-mr
vuule Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions cpp/src/io/comp/nvcomp_adapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@

#include "nvcomp_adapter.cuh"

#include <cudf/detail/nvtx/ranges.hpp>
#include <cudf/io/config_utils.hpp>
#include <cudf/logger.hpp>
#include <cudf/utilities/error.hpp>
#include <cudf/utilities/pinned_memory.hpp>

#include <nvcomp/deflate.h>
#include <nvcomp/gzip.h>
Expand All @@ -30,6 +32,26 @@

#include <mutex>

#define NVCOMP_HOST_PINNED_HEADER <nvcomp/host_pinned.hpp>
#if __has_include(NVCOMP_HOST_PINNED_HEADER)
#define NVCOMP_HAS_PINNED_MEMORY_RESOURCE_SUPPORT 1
#include NVCOMP_HOST_PINNED_HEADER
#else
#define NVCOMP_HAS_PINNED_MEMORY_RESOURCE_SUPPORT 0
#endif

// can't use nvcomp C++ functions under cudf::io::detail::nvcomp namespace :(
namespace {
[[maybe_unused]] void set_nvcomp_pinned_memory_resource()
{
#if NVCOMP_HAS_PINNED_MEMORY_RESOURCE_SUPPORT
static std::once_flag flag;
std::call_once(flag,
[]() { nvcomp::set_pinned_memory_resource(cudf::get_pinned_memory_resource()); });
#endif
}
} // namespace

namespace cudf::io::detail::nvcomp {
namespace {

Expand Down Expand Up @@ -268,6 +290,8 @@ void batched_decompress(compression_type compression,
size_t max_total_uncomp_size,
rmm::cuda_stream_view stream)
{
if constexpr (NVCOMP_HAS_PINNED_MEMORY_RESOURCE_SUPPORT) { set_nvcomp_pinned_memory_resource(); }

auto const num_chunks = inputs.size();

// cuDF inflate inputs converted to nvcomp inputs
Expand Down
Loading