Add pylibcudf.Scalar.to_py to avoid scalar conversion to host via pyarrow #19043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
Matt711
approved these changes
May 30, 2025
Comment on lines
181
to
184
| if not self.is_valid(): | ||
| return None | ||
| elif self.type().id() == type_id.BOOL8: | ||
| return (<numeric_scalar[cbool]*>self.c_obj.get()).value() |
There was a problem hiding this comment.
You could try storing these in variables self.type().id() and self.c_obj.get()
There was a problem hiding this comment.
Sure thing, good idea!
| @@ -168,6 +169,47 @@ cdef class Scalar: | |||
| """ | |||
| return _from_numpy(np_val) | |||
|
|
|||
| def to_py(self): | |||
There was a problem hiding this comment.
An old habit of mine before match existed in Python. I wouldn't be opposed to use match in the future
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #18921
Additionally adds a
expr.Literal.astypemethod to containLiteralcasting logic between 2DataTypes. This casting logic before was usingpylibcudfto cast between 2 scalars. I think this is an unnecessary operation to do on a GPU, so now this just performs the cast using Polars directly.Checklist