Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip conda-python-tests on arm64 #70

Open
wants to merge 2 commits into
base: branch-25.02
Choose a base branch
from

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Nov 15, 2024

All of this repo's conda-python-tests jobs have conditions in them like "skip on ARM":

rapids-logger "skipping cugraph_dgl pytest on ARM64"

rapids-logger "skipping cugraph_pyg pytest on ARM64"

rapids-logger "skipping pylibwholegraph pytest on ARM64"

As a result, right now the arm64 conda-python-tests jobs are just wasting CI resources... they're spending 40+ 5-10 minutes occupying a GPU runner just to download some datasets and then exit (example build link).

This proposes never even starting those jobs, to make CI here less expensive.

Notes for Reviewers

But why are we skipping arm at all?

Lack of pytorch packages. See #61 (comment)

@jameslamb jameslamb requested a review from a team as a code owner November 15, 2024 17:26
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 15, 2024
@jameslamb jameslamb changed the base branch from branch-24.12 to branch-25.02 November 25, 2024 16:08
@jameslamb
Copy link
Member Author

Looks like this didn't get in last week. It's not critical, so I've re-targeted it at branch-25.02.

Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants