Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.02 to branch-24.04 #4136

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

GPUtester
Copy link
Contributor

Forward-merge triggered by push to branch-24.02 that creates a PR to keep branch-24.04 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

…dds updates for pytest 8 compat, temporarily skips IO intensive test in CI (#4121)

* Adds option to rapids_cpm_find for raft to disable hnswlib feature, which is not needed by cugraph.  This resolves cmake failures such as the following:
   ```
        CMake Error at /home/coder/cugraph/cpp/build/release/_deps/raft-build/raft-targets.cmake:56 (set_target_properties):
         The link interface of target "raft::raft" contains:
  
           hnswlib::hnswlib
  
  
         but the target was not found. 
   ```
* TEMPORARILY skips bulk sampling IO tests which were hanging on CI runners. These tests pass locally, so we believe this is related to IO issues on CI runners, but will investigate further in 24.04
* Adds updates for pytest >=8
  * Adds option to pytest to append source paths to PYTHONPATH instead of prepend (the default). The prepended PYTHONPATH caused the dask `LocalCUDACluster` to import cugraph modules from the source tree instead of the install location, which resulted in `ImportError`s. This appears to be a behavior change in pytest 8.
  * Adds an `xfail` for an [NX test known to be incompatible with pytest>=8](networkx/networkx#7203)

Authors:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Ray Douglass (https://github.com/raydouglass)
  - Erik Welch (https://github.com/eriknw)

URL: #4121
@GPUtester GPUtester requested review from a team as code owners February 1, 2024 20:21
@GPUtester GPUtester merged commit 88c3070 into branch-24.04 Feb 1, 2024
28 checks passed
@GPUtester
Copy link
Contributor Author

SUCCESS - forward-merge complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants