Expose new all-pairs Similarity algorithms #4502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… similarity algorithms
ChuckHastings
added
improvement
ChuckHastings
approved these changes
Jul 9, 2024
…8_all-pairs-similarity
…8_all-pairs-similarity
rlratzel
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Thanks, Joseph! I didn't see any issues with the implementations but I have some comments about the docstrings.
Also, moving forward, we should probably have examples in the docstrings for each one. It would also be helpful if the examples showed at least some of the results so users can see what to expect.
rlratzel
approved these changes
Jul 30, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variation of the Similarity algorithms leveraging of all-pairs between vertices is available in the C and C++ API. It also enable the retrieval of the top k vertices.
This PR:
closes #4470